Addressed the review comments

twilio · Jun 28, 2021 · 8f7b136 · 8f7b136
1 parent e621ea6
commit 8f7b136
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/src/commands/profiles/create.js b/src/commands/profiles/create.js
@@ -218,17 +218,6 @@ class ProfilesCreate extends BaseCommand {
     }
   }
 
-  async removeKeytarKeysByProfileId(profileId) {
-    if (this.userConfig.projects.find((p) => p.id === profileId)) {
-      const removed = await this.secureStorage.removeCredentials(profileId);
-      if (removed === true) {
-        this.logger.info('Deleted key from keytar.');
-      } else {
-        this.logger.warn('Could not delete key from keytar.');
-      }
-    }
-  }
-
   async saveCredentials() {
     const apiKeyFriendlyName = this.getApiKeyFriendlyName();
     let apiKey = null;
@@ -250,6 +239,17 @@ class ProfilesCreate extends BaseCommand {
     );
     this.logger.info(configSavedMessage);
   }
+
+  async removeKeytarKeysByProfileId(profileId) {
+    if (this.userConfig.projects.find((p) => p.id === profileId)) {
+      const removed = await this.secureStorage.removeCredentials(profileId);
+      if (removed === true) {
+        this.logger.info('Deleted key from keytar.');
+      } else {
+        this.logger.warn(`Could not delete ${profileId} key from keytar.`);
+      }
+    }
+  }
 }
 
 ProfilesCreate.aliases = ['profiles:add', 'login'];

diff --git a/test/commands/profiles/create.test.js b/test/commands/profiles/create.test.js
@@ -16,9 +16,7 @@ describe('commands', () => {
           .twilioFakeProfile(ConfigData)
           .do((ctx) => {
             ctx.userConfig = new ConfigData();
-            for (let i = 0; i <= addProjects.length; i++) {
-              ctx.userConfig.addProject(addProjects[i], constants.FAKE_ACCOUNT_SID);
-            }
+            addProjects.forEach((project) => ctx.userConfig.addProject(project, constants.FAKE_ACCOUNT_SID));
           })
           .twilioCliEnv(Config)
           .twilioCreateCommand(ProfilesCreate, commandArgs)
@@ -98,7 +96,7 @@ describe('commands', () => {
           expect(ctx.stdout).to.equal('');
           expect(ctx.stderr).to.contain(helpMessages.AUTH_TOKEN_NOT_SAVED);
           expect(ctx.stderr).to.contain('Saved profile1.');
-          expect(ctx.stderr).to.contain('Could not delete key from keytar');
+          expect(ctx.stderr).to.contain('Could not delete profile1 key from keytar.');
           expect(ctx.stderr).to.contain('configuration saved');
           expect(ctx.stderr).to.contain(`Created API Key ${constants.FAKE_API_KEY} and stored the secret in Config.`);
           expect(ctx.stderr).to.contain(