Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins is not a constructor in 2.1.0 #187

Closed
johnmmason opened this issue May 28, 2020 · 1 comment · Fixed by #189
Closed

Plugins is not a constructor in 2.1.0 #187

johnmmason opened this issue May 28, 2020 · 1 comment · Fixed by #189
Labels
status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library

Comments

@johnmmason
Copy link

Issue Summary

This issue is a reoccurrence of issue #185 which occurred on 2.0.2 and was fixed in 2.0.3. I am experiencing the previously resolved issue on 2.1.0.

Steps to Reproduce

The issue occurred while running the command:

twilio phone-numbers:update "+15127175950" --sms-url="http://localhost:5000/sms" -l debug

Code Snippet

[DEBUG] Found ngrok version in "twilio-cli" optionalDependencies: ^3.2.7
 » Installing ngrok ...
[DEBUG] Found command "phone-numbers:update" plugin: twilio-cli
 » twilio-cli encountered an unexpected error. To report this issue, execute the command with the "-l debug" flag, then copy the output to a new issue here: "https://github.com/twilio/twilio-cli/issues"
[DEBUG] Plugins is not a constructor
[DEBUG] TypeError: Plugins is not a constructor
    at requireInstall (/usr/local/Cellar/twilio/2.1.0/libexec/node_modules/@twilio/cli-core/src/services/require-install.js:104:19)
    at NumberUpdate.install (/usr/local/Cellar/twilio/2.1.0/libexec/node_modules/@twilio/cli-core/src/base-commands/base-command.js:153:12)
    at NumberUpdate.run (/usr/local/Cellar/twilio/2.1.0/libexec/src/commands/phone-numbers/update.js:37:33)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async NumberUpdate._run (/usr/local/Cellar/twilio/2.1.0/libexec/node_modules/@oclif/command/lib/command.js:43:20)
    at async Config.runCommand (/usr/local/Cellar/twilio/2.1.0/libexec/node_modules/@oclif/config/lib/config.js:172:9)
    at async Main.run (/usr/local/Cellar/twilio/2.1.0/libexec/node_modules/@oclif/command/lib/main.js:22:9)
    at async Main._run (/usr/local/Cellar/twilio/2.1.0/libexec/node_modules/@oclif/command/lib/command.js:43:20)

Technical details:

  • twilio-cli version:
% twilio --version
twilio-cli/2.1.0 darwin-x64 node-v14.3.0
@childish-sambino childish-sambino mentioned this issue May 28, 2020
Closed
@childish-sambino
Copy link
Contributor

Able to recreate this locally. Looks like the previous fix is no longer valid due to transitive dependency issues. Checking for what the proper fix should be ...

@childish-sambino childish-sambino added status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library labels May 28, 2020
childish-sambino pushed a commit that referenced this issue May 29, 2020
fix: pin 'tslib' to avoid issues when interacting with plugin-plugins
a8d1f35 
This is a patch to fix #187 and is similar to twilio/twilio-cli-core#88. Still working on a more proper fix.

The 'plugin-plugins' module was not loading properly because of some bug in 'tslib-1.12.0'. Users would see the error `TypeError: Plugins is not a constructor` when attempting to install a runtime dependency.
@childish-sambino childish-sambino mentioned this issue May 29, 2020
Merged
childish-sambino pushed a commit that referenced this issue May 29, 2020
fix: pin 'tslib' to avoid issues when interacting with plugin-plugins
c1cd0a2 
This is a patch to fix #187 and is similar to twilio/twilio-cli-core#88. Still working on a more proper fix.

The 'plugin-plugins' module was not loading properly because of some bug in 'tslib-1.12.0'. Users would see the error `TypeError: Plugins is not a constructor` when attempting to install a runtime dependency.
childish-sambino pushed a commit that referenced this issue Jun 2, 2020
fix: pin 'tslib' to avoid issues when interacting with plugin-plugins (…
b558f27 
…#189)

This is a patch to fix #187 and is similar to twilio/twilio-cli-core#88. Still working on a more proper fix.

The 'plugin-plugins' module was not loading properly because of some bug in 'tslib-1.12.0'. Users would see the error `TypeError: Plugins is not a constructor` when attempting to install a runtime dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pin 'tslib' to avoid issues when interacting with plugin-plugins twilio/twilio-cli
2 participants
@childish-sambino @johnmmason