Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'target-account-sid' flag for transferring phone numbers #115

Merged
merged 2 commits into from
Sep 5, 2019

Conversation

childish-sambino
Copy link
Contributor

Also adds a warning messages when a command contains conflicting flags/params.

Sam Harrison added 2 commits September 5, 2019 12:17
Also adds a warning messages when a command contains conflicting flags/params.
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #115 into master will decrease coverage by 0.1%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   98.51%   98.41%   -0.11%     
==========================================
  Files          27       27              
  Lines         809      820      +11     
==========================================
+ Hits          797      807      +10     
- Misses         12       13       +1
Impacted Files Coverage Δ
src/services/twilio-api/get-flag-config.js 100% <100%> (ø) ⬆️
src/services/twilio-api/api-command-runner.js 100% <100%> (ø) ⬆️
src/base-commands/twilio-api-command.js 95.83% <75%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b91b16...08c3124. Read the comment docs.

@childish-sambino childish-sambino merged commit 3bc2238 into master Sep 5, 2019
@childish-sambino childish-sambino deleted the target-account-sid branch September 5, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants