Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ngrok an optional dependency since it is installed at runtime #140

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

childish-sambino
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          27       27           
  Lines         809      809           
=======================================
  Hits          795      795           
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28da6b6...448aa00. Read the comment docs.

@childish-sambino childish-sambino merged commit 6982963 into master Nov 21, 2019
@childish-sambino childish-sambino deleted the optional-ngrok branch November 21, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants