Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user when creating default project with env vars set #21

Merged
merged 1 commit into from
May 8, 2019

Conversation

childish-sambino
Copy link
Contributor

@childish-sambino childish-sambino commented May 8, 2019

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Short description of what this PR does:

  • If the user has credential env vars set when adding/updating the default project, they are prompted to continue or cancel

If you have questions, please file a support ticket, or create a Github Issue in this repository.

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #21 into master will increase coverage by 1.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   97.02%   98.04%   +1.01%     
==========================================
  Files          20       20              
  Lines         505      512       +7     
==========================================
+ Hits          490      502      +12     
+ Misses         15       10       -5
Impacted Files Coverage Δ
src/commands/project/add.js 96.66% <100%> (+6.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272564b...0d6454d. Read the comment docs.

@childish-sambino childish-sambino merged commit 5c99608 into master May 8, 2019
@childish-sambino childish-sambino deleted the env-vars-first branch May 8, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants