Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add sonarcloud configurations #276

Merged
merged 2 commits into from
Jul 30, 2021
Merged

chore: Add sonarcloud configurations #276

merged 2 commits into from
Jul 30, 2021

Conversation

onuzbee
Copy link
Contributor

@onuzbee onuzbee commented Jul 29, 2021 •
edited
Loading

Closes

Closes DI-1381.

Adds sonarcloud configurations. Related PR in twilio-cli-core with tested main push: Link

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ravali-rimmalapudi
ravali-rimmalapudi reviewed Jul 30, 2021
View reviewed changes
sonar-project.properties
@@ -0,0 +1,8 @@
sonar.projectKey=twilio_twilio-cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] Where are we using these properties?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key is generated by Sonar dashboard, which needs to be a 1:1 mapping between repositories.
Helps sonar to link a CI build to it's dashboard view.

ravali-rimmalapudi
ravali-rimmalapudi reviewed Jul 30, 2021
View reviewed changes
sonar-project.properties

sonar.sources=src/
sonar.tests=test/
# sonar.test.exclusions= < No exclusions currently >
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: If not required, we can remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've deliberately added this to avoid checking documentation back again for skipping some specific test branches.

ravali-rimmalapudi
ravali-rimmalapudi reviewed Jul 30, 2021
View reviewed changes
.travis.yml
addons:
sonarcloud:
token:
secure: HoD6oJ03Y60apDszjFZ8AN+ujnkbQAPM41bBb/YNNMtgslfnJPp63bQy5m0hoCsTVRoPiZvuZRpfxQpcJLmlEScY4ulQI7DRf+FFh6/2B80+kl1FRLsyar0/JtZvn/LDsP5GjksIZUD2cdPho2rRnmGiS9bmrKIc4YRKKxMO/zi33EUPgiwea23rCB/6/CK6AnAyD7ufwM/ldewqKiU5T67IbAQM2mKEMqyM+oPSx/HL6f9NrtpenZs9pP3y8oRCCty8yP5BOyoLqOJvn0lRqdAAL5S8Jsrb6NB7Mk+lrU4AcfcgEmDGbj+wKFdV/xlqZcCDGDvytqGocGsQZLwbaNlOzSTkoJVvzy1crMxySsqVFoGusISPXA3iJgBQn08E8bwSI1SWDfdvQTFZFYcoc/1OWNutH6EvoHC9uM9rmIRJPVDqGeBevlJq7vffspnuwpWZeH6hWQt7kHBGxQSYtCyOUkFU0IntRFiX2KvyP38rRIlfeoDM2fqaD/NUg0+C77YYhi9on74mQrw8EEjq5QErht458shfjiPPoq8PHpN2WNXjJ8lRHc6h8eqNzX0Uz2ooPOvxgFnyjergBbe5KADQkPLhJehZQhNtHiAfAX5dtkP8IJizu0tpwrTkMWrMMT51nbqL/zOtH6yflr1+AjKrLM7YFRSj8by3yokNzI4=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] Is this token generated from sonar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used travis encryption for sonar cloud token

travis encrypt --add addons.sonarcloud.token <SONAR_TOKEN>

ravali-rimmalapudi
ravali-rimmalapudi reviewed Jul 30, 2021
View reviewed changes
Copy link
Contributor

@ravali-rimmalapudi ravali-rimmalapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@onuzbee onuzbee merged commit e1b5339 into main Jul 30, 2021
@onuzbee onuzbee deleted the integrate-sonar branch July 30, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravali-rimmalapudi ravali-rimmalapudi ravali-rimmalapudi approved these changes

@kridai kridai Awaiting requested review from kridai

@sr010 sr010 Awaiting requested review from sr010

@shrutiburman shrutiburman Awaiting requested review from shrutiburman

@Sindhura3 Sindhura3 Awaiting requested review from Sindhura3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onuzbee @ravali-rimmalapudi @Sindhura3