fix: test cases having non-deterministic behaviour #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutiburman
requested review from
Sindhura3,
kridai,
onuzbee,
ravali-rimmalapudi and
sr010
shrutiburman
commented
Oct 4, 2021
| const result = convertToHyperlink('MORE INFO', 'https://twilio.com/docs/dummyCmd').isSupported; | ||
| if ('CI' in process.env) { |
There was a problem hiding this comment.
Since the hyperlink flag --hyperlink is set to true, it'll be honoured in CI environments too. Reference.
| expect( | ||
| getFlagConfig( | ||
| { | ||
| name: 'DummyCmd', | ||
| schema: { | ||
| description: | ||
| "The SID of the [Account](https://www.twilio.com/docs/iam/api/account) to which the Sim resource should belong. Account or that of a [Subaccount](https://www.twilio.com/docs/iam/api/subaccounts) of the requesting Account. Only valid when the Sim resource's status is `new`. For more information, see the [Move SIMs between Subaccounts documentation](https://www.twilio.com/docs/wireless/api/sim-resource#move-sims-between-subaccounts).", | ||
| 'The SID of the [Account](https://www.twi lio.com/docs/iam/api/account) to which the Sim resource should belong. ', |
There was a problem hiding this comment.
Is the gap twi lio is intentional ?
There was a problem hiding this comment.
Yes, that's to verify the markdown regex. With space it would be an invalid markdown. This is a useful reference to verify markdowns.
ravali-rimmalapudi
previously approved these changes
Oct 4, 2021
shrutiburman
force-pushed
the
136-fix-test-cases
branch
from
b62e456
to
792ba0a
Compare
ravali-rimmalapudi
approved these changes
Oct 5, 2021
kridai
approved these changes
Oct 5, 2021
onuzbee
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 136
Testing Gist
This PR solves:
Some test cases were not passing uniformly, when the
process.envvariable is modified to mock different terminals(failed when ran individually and passed when ran in the suite).This is a known issue with mocha when combined with
supports-color. supports-color is an internal dependency insupports-hyperlink.This issue is resolved for Emacs users, however in IDE terminals it still causes problems, there's this agreed workaround which fixes it.
Screenshots:
In VSCode:
In IntelliJ:
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.