Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the API plugin init synchronous so other hook processors can be run after #35

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

childish-sambino
Copy link
Contributor

Fixes

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Short description of what this PR does:

  • Make the API plugin initialization synchronous so future init hook processors will always be run after it completes

If you have questions, please file a support ticket, or create a Github Issue in this repository.

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@bdf1775). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #35   +/-   ##
========================================
  Coverage          ?   98.4%           
========================================
  Files             ?      22           
  Lines             ?     565           
  Branches          ?       0           
========================================
  Hits              ?     556           
  Misses            ?       9           
  Partials          ?       0
Impacted Files Coverage Δ
src/hooks/init/twilio-api.js 100% <100%> (ø)
src/hooks/init/plugin-verification.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf1775...29f8cb0. Read the comment docs.

"post-api-plugin": "./src/hooks/post-api-plugin/plugin-verification"
"init": [
"./src/hooks/init/twilio-api",
"./src/hooks/init/plugin-verification"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, clean and readable :)

@childish-sambino childish-sambino merged commit 5713ed9 into master Jun 6, 2019
@childish-sambino childish-sambino deleted the init-hook branch June 6, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants