-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changes for default output property #377
Conversation
added changes to check for default output property at operation level, if not present fallback to path level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@kridai should package-lock.json be a part of this? It's going to cause conflicts |
0e25c07
updated, Thanks for catching that. |
added changes to check for default output property at operation level, if not present fallback to path level
Fixes
Fixes: DII-99
Since we are introducing the custom property at operation level to track defaultOutputProperty as part of the yps changes , We also need to make the necessary changes in twilio-cli, we need to give preference to default output property present at operation level (post/get etc), if not present fallback to property defined at path level
In the above example default output property included
binding
property for create operation, but was not specified for list operationChecklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.