Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changes for default output property #377

Merged
merged 5 commits into from
Feb 2, 2022

Conversation

kridai
Copy link
Contributor

@kridai kridai commented Feb 1, 2022

added changes to check for default output property at operation level, if not present fallback to path level

Fixes

Fixes: DII-99

Since we are introducing the custom property at operation level to track defaultOutputProperty as part of the yps changes , We also need to make the necessary changes in twilio-cli, we need to give preference to default output property present at operation level (post/get etc), if not present fallback to property defined at path level

Screenshot 2022-02-01 at 5 44 17 AM

In the above example default output property included binding property for create operation, but was not specified for list operation

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

added changes to check for default output property at operation level, if not present fallback to path level
Copy link
Contributor

@ravali-rimmalapudi ravali-rimmalapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

onuzbee
onuzbee previously approved these changes Feb 1, 2022
Copy link
Contributor

@onuzbee onuzbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

shrutiburman
shrutiburman previously approved these changes Feb 1, 2022
Copy link
Contributor

@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Sindhura3
Copy link
Contributor

@kridai should package-lock.json be a part of this? It's going to cause conflicts

sr010
sr010 previously approved these changes Feb 2, 2022
@kridai
Copy link
Contributor Author

kridai commented Feb 2, 2022

@kridai should package-lock.json be a part of this? It's going to cause conflicts

updated, Thanks for catching that.

Sindhura3
Sindhura3 previously approved these changes Feb 2, 2022
@kridai kridai merged commit 980b059 into twilio:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants