Add --skip-parameter-validation flag #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
======================================
Coverage 98.8% 98.8%
======================================
Files 26 26
Lines 754 754
======================================
Hits 745 745
Misses 9 9
Continue to review full report at Codecov.
|
| @@ -44,7 +44,7 @@ class ApiCommandRunner { | |||
|
|
|||
| // If there were any errors validating the flag values, log them by flag | |||
| // key and throw. | |||
| if (Object.keys(flagErrors).length > 0) { | |||
| if (Object.keys(flagErrors).length > 0 && !this.flagValues['skip-parameter-validation']) { | |||
There was a problem hiding this comment.
Is it beneficial to log the errors but not throw?
There was a problem hiding this comment.
Was on vacation @childish-sambino ... it wouldn't be beneficial for the tricorder use-case.
k-talluri
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Contributing to Twilio
Short description of what this PR does:
--skip-parameter-validationflag to API commandsIf you have questions, please file a support ticket, or create a Github Issue in this repository.