Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements #92

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Documentation improvements #92

merged 1 commit into from
Aug 3, 2019

Conversation

dprothero
Copy link
Contributor

@dprothero dprothero commented Aug 3, 2019

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Short description of what this PR does:

  1. The plugins docs have moved to their own page at twilio.com/docs/twilio-cli/plugins
  2. The ngrok integration was reworded to focus on the benefit to the user, rather than the technical implementation
  3. Added a security warning about the tunnel/proxy
  4. Added a final, missing step to plugin authoring

@codecov
Copy link

codecov bot commented Aug 3, 2019

Codecov Report

Merging #92 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files          26       26           
  Lines         785      785           
=======================================
  Hits          773      773           
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612f3d7...d48f44a. Read the comment docs.

@dprothero dprothero merged commit 603a783 into master Aug 3, 2019
@dprothero dprothero deleted the docs-improvements branch August 3, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants