Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationRequestResult param should be optional #20

Closed
Beans0063 opened this issue Nov 23, 2011 · 1 comment
Closed

ValidationRequestResult param should be optional #20

Beans0063 opened this issue Nov 23, 2011 · 1 comment

Comments

@Beans0063
Copy link

Per the docs method signature should be: ValidationRequestResult AddOutgoingCallerId (phoneNumber, friendlyName, callDelay)

From OutgoingCallerIds.cs there is a required fourth param:

public ValidationRequestResult AddOutgoingCallerId(string phoneNumber, string friendlyName, int? callDelay, string extension)

Please make extension optional to preserve compatibility.

@devinrader
Copy link
Contributor

In this case the user can just specify an empty string. C# does not have the notion of optional parameters.

devinrader pushed a commit that referenced this issue Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants