Updated Twilio.Types.Client implementation of IEndpoint to function as expected #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
childish-sambino
approved these changes
May 21, 2019
|
Actually, need to do case-insensitive comparison since |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #402
Passing a
Clientinstance toCallResource.Create()'s to parameter will now work as expected.The
CallOptionsandCallResourceclasses look like they need updating on the Twilio REST API side to accept implementations ofIEndpointin their From parameters as the code is generated by Yoyodine.It would also be nice if client names with dashes and other special characters were allowed using the REST API like they are using TwiML.