Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add details to api exception #519

Merged
merged 4 commits into from Apr 28, 2020

Conversation

ashish-s
Copy link
Contributor

@ashish-s ashish-s commented Apr 21, 2020

Feature

Add a new property named details to ApiException and RestException. Details is returned by selective apis to populate extra information about errors.
The Studio V2 flow api will be returning extra details with flow validation errors.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

src/Twilio/Exceptions/ApiException.cs Outdated Show resolved Hide resolved
src/Twilio/Exceptions/ApiException.cs Outdated Show resolved Hide resolved
src/Twilio/Exceptions/ApiException.cs Outdated Show resolved Hide resolved
test/Twilio.Test/Clients/TwilioRestClientTest.cs Outdated Show resolved Hide resolved
test/Twilio.Test/Clients/TwilioRestClientTest.cs Outdated Show resolved Hide resolved
test/Twilio.Test/Clients/TwilioRestClientTest.cs Outdated Show resolved Hide resolved
test/Twilio.Test/Clients/TwilioRestClientTest.cs Outdated Show resolved Hide resolved
@ashish-s
Copy link
Contributor Author

@childish-sambino fixed the formatting issues.

@childish-sambino childish-sambino merged commit ff7e17c into twilio:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants