Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add RecordingRule and RecordingRulesUpdate #527

Merged
merged 4 commits into from
Oct 13, 2020
Merged

feat: Add RecordingRule and RecordingRulesUpdate #527

merged 4 commits into from
Oct 13, 2020

Conversation

FalguniV
Copy link
Contributor

@FalguniV FalguniV commented Jun 26, 2020 •
edited

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

childish-sambino
childish-sambino reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing these new types used anywhere. Could you point to the docs on where this should be referenced?

@childish-sambino childish-sambino added the status: waiting for feedback waiting for feedback from the submitter label Jul 2, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:39
@childish-sambino
Copy link
Contributor

Closing for now. Please ping to re-open when you're ready. Or open a new PR.

@childish-sambino childish-sambino added status: invalid issues not related to the library and removed status: waiting for feedback waiting for feedback from the submitter labels Aug 7, 2020
@childish-sambino childish-sambino merged commit 3e4ee37 into twilio:main Oct 13, 2020
@FalguniV FalguniV deleted the recordingRules branch October 13, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerverse innerverse innerverse approved these changes

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: invalid issues not related to the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FalguniV @childish-sambino @innerverse