Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle missing "from" parameter exception #639

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

isha689
Copy link
Contributor

@isha689 isha689 commented Oct 18, 2022

Fixes

Resolved #539 as part of this PR.
Serialization was failing when 'from' parameter was null, so added a check to handle the null values.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sbansla sbansla self-requested a review October 18, 2022 12:44
@sbansla sbansla merged commit ae8d593 into 6.0.0-rc Oct 18, 2022
@sbansla sbansla deleted the resolving-issue-539 branch October 18, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants