Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling number parameters serialization #659

Merged
merged 1 commit into from
Dec 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Twilio/Rest/Api/V2010/Account/Call/NotificationOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,11 @@ public ReadNotificationOptions(string pathCallSid)
}
if (MessageDateBefore != null)
{
p.Add(new KeyValuePair<string, string>("MessageDateBefore", MessageDateBefore.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("MessageDate<", MessageDateBefore.Value.ToString("yyyy-MM-dd")));
}
if (MessageDateAfter != null)
{
p.Add(new KeyValuePair<string, string>("MessageDateAfter", MessageDateAfter.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("MessageDate>", MessageDateAfter.Value.ToString("yyyy-MM-dd")));
}
if (PageSize != null)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Twilio/Rest/Api/V2010/Account/Call/PaymentOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public CreatePaymentOptions(string pathCallSid, string idempotencyKey, Uri statu
}
if (ChargeAmount != null)
{
p.Add(new KeyValuePair<string, string>("ChargeAmount", ChargeAmount.ToString()));
p.Add(new KeyValuePair<string, string>("ChargeAmount", ChargeAmount.Value.ToString()));
}
if (Currency != null)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Twilio/Rest/Api/V2010/Account/Call/RecordingOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -222,11 +222,11 @@ public ReadRecordingOptions(string pathCallSid)
}
if (DateCreatedBefore != null)
{
p.Add(new KeyValuePair<string, string>("DateCreatedBefore", DateCreatedBefore.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("DateCreated<", DateCreatedBefore.Value.ToString("yyyy-MM-dd")));
}
if (DateCreatedAfter != null)
{
p.Add(new KeyValuePair<string, string>("DateCreatedAfter", DateCreatedAfter.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("DateCreated>", DateCreatedAfter.Value.ToString("yyyy-MM-dd")));
}
if (PageSize != null)
{
Expand Down
396 changes: 198 additions & 198 deletions src/Twilio/Rest/Api/V2010/Account/Call/SiprecOptions.cs

Large diffs are not rendered by default.

396 changes: 198 additions & 198 deletions src/Twilio/Rest/Api/V2010/Account/Call/StreamOptions.cs

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions src/Twilio/Rest/Api/V2010/Account/CallOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -443,11 +443,11 @@ public class ReadCallOptions : ReadOptions<CallResource>
}
if (StartTimeBefore != null)
{
p.Add(new KeyValuePair<string, string>("StartTimeBefore", Serializers.DateTimeIso8601(StartTimeBefore)));
p.Add(new KeyValuePair<string, string>("StartTime<", Serializers.DateTimeIso8601(StartTimeBefore)));
}
if (StartTimeAfter != null)
{
p.Add(new KeyValuePair<string, string>("StartTimeAfter", Serializers.DateTimeIso8601(StartTimeAfter)));
p.Add(new KeyValuePair<string, string>("StartTime>", Serializers.DateTimeIso8601(StartTimeAfter)));
}
if (EndTime != null)
{
Expand All @@ -467,11 +467,11 @@ public class ReadCallOptions : ReadOptions<CallResource>
}
if (EndTimeBefore != null)
{
p.Add(new KeyValuePair<string, string>("EndTimeBefore", Serializers.DateTimeIso8601(EndTimeBefore)));
p.Add(new KeyValuePair<string, string>("EndTime<", Serializers.DateTimeIso8601(EndTimeBefore)));
}
if (EndTimeAfter != null)
{
p.Add(new KeyValuePair<string, string>("EndTimeAfter", Serializers.DateTimeIso8601(EndTimeAfter)));
p.Add(new KeyValuePair<string, string>("EndTime>", Serializers.DateTimeIso8601(EndTimeAfter)));
}
if (PageSize != null)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,11 @@ public ReadRecordingOptions(string pathConferenceSid)
}
if (DateCreatedBefore != null)
{
p.Add(new KeyValuePair<string, string>("DateCreatedBefore", DateCreatedBefore.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("DateCreated<", DateCreatedBefore.Value.ToString("yyyy-MM-dd")));
}
if (DateCreatedAfter != null)
{
p.Add(new KeyValuePair<string, string>("DateCreatedAfter", DateCreatedAfter.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("DateCreated>", DateCreatedAfter.Value.ToString("yyyy-MM-dd")));
}
if (PageSize != null)
{
Expand Down
8 changes: 4 additions & 4 deletions src/Twilio/Rest/Api/V2010/Account/ConferenceOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,11 @@ public class ReadConferenceOptions : ReadOptions<ConferenceResource>
}
if (DateCreatedBefore != null)
{
p.Add(new KeyValuePair<string, string>("DateCreatedBefore", DateCreatedBefore.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("DateCreated<", DateCreatedBefore.Value.ToString("yyyy-MM-dd")));
}
if (DateCreatedAfter != null)
{
p.Add(new KeyValuePair<string, string>("DateCreatedAfter", DateCreatedAfter.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("DateCreated>", DateCreatedAfter.Value.ToString("yyyy-MM-dd")));
}
if (DateUpdated != null)
{
Expand All @@ -137,11 +137,11 @@ public class ReadConferenceOptions : ReadOptions<ConferenceResource>
}
if (DateUpdatedBefore != null)
{
p.Add(new KeyValuePair<string, string>("DateUpdatedBefore", DateUpdatedBefore.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("DateUpdated<", DateUpdatedBefore.Value.ToString("yyyy-MM-dd")));
}
if (DateUpdatedAfter != null)
{
p.Add(new KeyValuePair<string, string>("DateUpdatedAfter", DateUpdatedAfter.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("DateUpdated>", DateUpdatedAfter.Value.ToString("yyyy-MM-dd")));
}
if (FriendlyName != null)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Twilio/Rest/Api/V2010/Account/Message/MediaOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,11 @@ public ReadMediaOptions(string pathMessageSid)
}
if (DateCreatedBefore != null)
{
p.Add(new KeyValuePair<string, string>("DateCreatedBefore", Serializers.DateTimeIso8601(DateCreatedBefore)));
p.Add(new KeyValuePair<string, string>("DateCreated<", Serializers.DateTimeIso8601(DateCreatedBefore)));
}
if (DateCreatedAfter != null)
{
p.Add(new KeyValuePair<string, string>("DateCreatedAfter", Serializers.DateTimeIso8601(DateCreatedAfter)));
p.Add(new KeyValuePair<string, string>("DateCreated>", Serializers.DateTimeIso8601(DateCreatedAfter)));
}
if (PageSize != null)
{
Expand Down
6 changes: 3 additions & 3 deletions src/Twilio/Rest/Api/V2010/Account/MessageOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public CreateMessageOptions(Types.PhoneNumber to)
}
if (MaxPrice != null)
{
p.Add(new KeyValuePair<string, string>("MaxPrice", MaxPrice.ToString()));
p.Add(new KeyValuePair<string, string>("MaxPrice", MaxPrice.Value.ToString()));
}
if (ProvideFeedback != null)
{
Expand Down Expand Up @@ -327,11 +327,11 @@ public class ReadMessageOptions : ReadOptions<MessageResource>
}
if (DateSentBefore != null)
{
p.Add(new KeyValuePair<string, string>("DateSentBefore", Serializers.DateTimeIso8601(DateSentBefore)));
p.Add(new KeyValuePair<string, string>("DateSent<", Serializers.DateTimeIso8601(DateSentBefore)));
}
if (DateSentAfter != null)
{
p.Add(new KeyValuePair<string, string>("DateSentAfter", Serializers.DateTimeIso8601(DateSentAfter)));
p.Add(new KeyValuePair<string, string>("DateSent>", Serializers.DateTimeIso8601(DateSentAfter)));
}
if (PageSize != null)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Twilio/Rest/Api/V2010/Account/NotificationOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,11 @@ public class ReadNotificationOptions : ReadOptions<NotificationResource>
}
if (MessageDateBefore != null)
{
p.Add(new KeyValuePair<string, string>("MessageDateBefore", MessageDateBefore.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("MessageDate<", MessageDateBefore.Value.ToString("yyyy-MM-dd")));
}
if (MessageDateAfter != null)
{
p.Add(new KeyValuePair<string, string>("MessageDateAfter", MessageDateAfter.Value.ToString("yyyy-MM-dd")));
p.Add(new KeyValuePair<string, string>("MessageDate>", MessageDateAfter.Value.ToString("yyyy-MM-dd")));
}
if (PageSize != null)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Twilio/Rest/Api/V2010/Account/RecordingOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,11 @@ public class ReadRecordingOptions : ReadOptions<RecordingResource>
}
if (DateCreatedBefore != null)
{
p.Add(new KeyValuePair<string, string>("DateCreatedBefore", Serializers.DateTimeIso8601(DateCreatedBefore)));
p.Add(new KeyValuePair<string, string>("DateCreated<", Serializers.DateTimeIso8601(DateCreatedBefore)));
}
if (DateCreatedAfter != null)
{
p.Add(new KeyValuePair<string, string>("DateCreatedAfter", Serializers.DateTimeIso8601(DateCreatedAfter)));
p.Add(new KeyValuePair<string, string>("DateCreated>", Serializers.DateTimeIso8601(DateCreatedAfter)));
}
if (CallSid != null)
{
Expand Down
Loading