Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: MVR Ready #728

Merged
merged 65 commits into from
Feb 23, 2024
Merged

feat!: MVR Ready #728

merged 65 commits into from
Feb 23, 2024

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Feb 23, 2024 •
edited

Fixes

Merging RC branch to main branch. It contains RC branch changes for all apis.
.net upgraded to .net6
Added Breaking Change(feat!:) commit.
Code tested with latest changes of open-api with
make install
make test

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

sbansla and others added 30 commits September 8, 2023 16:57
@sbansla
chore: added custom converters for nested objects (#688)
84a4c5c
@tiwarishubham635
feat: added json request body support in csharp (#686)
efe312c
@tiwarishubham635
chore: Updated csharp rc version and changed Request constructor
c5d50dc
@tiwarishubham635
chore: Updated csharp rc version and changed Request constructor (#692)
d99a6ee 
* chore: Updated csharp rc version and changed Request constructor

* fix: Removed GetParams from Resource interface
@tiwarishubham635
fix: removed unused abstract function getParam
d845e4c
@tiwarishubham635
Merge remote-tracking branch 'origin/7.0.0-rc' into 7.0.0-rc
ea9cf82
@tiwarishubham635
fix: removed unused constructor (#697)
5f5bd13
@sbansla
upgraded to .net6 (#690)
e9dfe60
@tiwarishubham635
chore: Updating changes with main (#703)
d5734e1
@sbansla
chore: Pull from main branch (#706)
499543c
@sbansla
chore: RC Release
c66d2c7
@sbansla
Update CHANGES.md
135e15e
@sbansla
Update CHANGES.md
5af110f
@sbansla
Update test-and-deploy.yml
92c322c
@sbansla
modified dotnet version for build
f68da1a
@sbansla
modified dotnet version for build
2633d92
@sbansla
chore: added net6 output path
ad190a0
@sbansla
chore: corrected net6 dll path
2ffb02b
@sbansla
chore: removed .net7 from ubuntu machine
c2d99b9
@twilio-dx
[Librarian] Regenerated @ 922c1fef02b8c8fbbbe2315aa9b9d1dba49f3fc0 5b…
293717e 
…60b450c9c432b54c4deb72e3b13fabf324647e
@twilio-dx
Release 7.0.0-rc.2
e2ed347
@twilio-dx
[Librarian] Regenerated @ 5eb406c4977c9f6976e6053cb5b581056f541a59 5a…
624b3b1 
…3ea6d4d73136543d9935ddd170bf3620d15c46
@twilio-dx
Release 7.0.0-rc.3
e5328aa
@sbansla
upgrading to .net7
65cc19e
@AsabuHere
Removing GenerateOnBuild attribute from csproj file
8c014d7
@sbansla
reverting rc version in changes.md
b075b89
@sbansla
changing dotnet version
f5d2324
@AsabuHere
Revert "Removing GenerateOnBuild attribute from csproj file"
1eb2d08 
This reverts commit 8c014d7.
@sbansla
chore: disable cluster tests
77682f8
@tiwarishubham635
chore: added code signing workflow (#720)
c9ec182
sbansla and others added 24 commits February 15, 2024 11:41
@sbansla
removed dotnet3 and 6
d664ce7
@sbansla
removed dependencies from ubuntu
13d46be
@sbansla
fix dependencies
0c8a2d1
@sbansla
force install
791f6e4
@sbansla
disable docker release
57d2d77
@sbansla
changed sdk version
40f985a
@sbansla
test
a1058d8
@sbansla
test
5d5dcb5
@sbansla
test
cbd0e18
@sbansla
test
f3e6bb0
@tiwarishubham635
chore: corrected repo name in code-signing workflow (#726)
f9a0b2f
@sbansla
changed .net version
e42692b
@sbansla
Merge branch '7.0.0-rc' of https://github.com/twilio/twilio-csharp in…
9fb5317 
…to 7.0.0-rc
@sbansla
chore: content api changes
a0e0631
@sbansla
added to changes.md
8a651a6
@sbansla
build env changed to .net6
82e4bf6
@sbansla
corrected dotnet installed version
aed5974
@sbansla
picking dotnet version from global.json
a402531
@sbansla
picking dotnet version from global.json
a66d60a
@sbansla
making c# mvr ready
e9ae26a
@sbansla
chore: taking main changes
d448a6f
@sbansla
chore: sync with main
f8d2ce8
@sbansla
preparing mvr
634f96a
@sbansla
sync with main branch
a2366c1
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed

Issues
18 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

tiwarishubham635
tiwarishubham635 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbansla sbansla merged commit 90cccf3 into main Feb 23, 2024
13 checks passed
@sbansla sbansla deleted the 7.0.0-rc-copy branch February 23, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiwarishubham635 tiwarishubham635 tiwarishubham635 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbansla @tiwarishubham635 @twilio-dx @AsabuHere