Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove redundant env var tests #66

Merged
merged 2 commits into from
Apr 21, 2021
Merged

chore: remove redundant env var tests #66

merged 2 commits into from
Apr 21, 2021

Conversation

eshanholtz
Copy link
Contributor

@eshanholtz eshanholtz commented Apr 21, 2021 •
edited

Removes redundant tests. ABD

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@eshanholtz eshanholtz mentioned this pull request Apr 21, 2021
Merged
childish-sambino
childish-sambino approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#ABD

@eshanholtz eshanholtz changed the title tests: remove unnecessary env var tests tests: remove redundant env var tests Apr 21, 2021
@eshanholtz eshanholtz merged commit 26670cd into main Apr 21, 2021
@eshanholtz eshanholtz deleted the env-var-test branch April 21, 2021 20:31
@thinkingserious thinkingserious changed the title tests: remove redundant env var tests chore: remove redundant env var tests Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eshanholtz @childish-sambino