-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add pagination #92
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwetha-manvinkurke
force-pushed
the
paging
branch
from
July 3, 2021 01:06
678b33b
to
806a250
Compare
shwetha-manvinkurke
force-pushed
the
paging
branch
from
July 12, 2021 15:29
4630545
to
fce11e4
Compare
shwetha-manvinkurke
force-pushed
the
paging
branch
from
July 12, 2021 15:43
7fe4462
to
26904c7
Compare
shwetha-manvinkurke
force-pushed
the
paging
branch
from
July 13, 2021 19:34
720f7df
to
17adfbc
Compare
eshanholtz
reviewed
Jul 13, 2021
shwetha-manvinkurke
force-pushed
the
paging
branch
from
July 13, 2021 20:04
ae8b89d
to
50a6848
Compare
shwetha-manvinkurke
force-pushed
the
paging
branch
from
July 14, 2021 18:23
f9f947f
to
2e9a777
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High-level structure looks solid. Some comments about improvements to better match the other helpers.
shwetha-manvinkurke
force-pushed
the
paging
branch
from
July 16, 2021 15:08
47a1d7a
to
d90a541
Compare
childish-sambino
approved these changes
Jul 16, 2021
eshanholtz
reviewed
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build pagination logic and functions