Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add pagination #92

Merged
merged 10 commits into from
Jul 16, 2021
Merged

feat!: add pagination #92

merged 10 commits into from
Jul 16, 2021

Conversation

shwetha-manvinkurke
Copy link
Contributor

Build pagination logic and functions

client/page.go Outdated Show resolved Hide resolved
@shwetha-manvinkurke shwetha-manvinkurke marked this pull request as draft July 7, 2021 17:24
rest/accounts/v1/credentials_aws.go Outdated Show resolved Hide resolved
rest/accounts/v1/credentials_aws.go Outdated Show resolved Hide resolved
client/page.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
rest/accounts/v1/credentials_aws.go Outdated Show resolved Hide resolved
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High-level structure looks solid. Some comments about improvements to better match the other helpers.

rest/accounts/v1/credentials_aws.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@shwetha-manvinkurke shwetha-manvinkurke merged commit 7b23345 into main Jul 16, 2021
@shwetha-manvinkurke shwetha-manvinkurke deleted the paging branch July 16, 2021 15:47
@shwetha-manvinkurke shwetha-manvinkurke changed the title feat: add pagination feat!: add pagination Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants