Ability to add undocumented options to requests #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejudas
reviewed
Jan 10, 2017
| @@ -128,6 +134,9 @@ public String apply(ConferenceEvent event) { | |||
| @XmlValue | |||
| private final String name; | |||
|
|
|||
| @XmlAnyAttribute | |||
| private Map<QName, String> options; | |||
There was a problem hiding this comment.
Will the XML serializer work serializing the key to a QName?
There was a problem hiding this comment.
@efossier Yes. I specifically choose QName for this reason.
jingming
reviewed
Jan 10, 2017
| @@ -224,6 +234,16 @@ public String getName() { | |||
| return name; | |||
| } | |||
|
|
|||
| public Map<String, String> getOptions() { | |||
| Map<String, String> convertedMap = new HashMap(); | |||
There was a problem hiding this comment.
should be using the <> here?
|
+1 |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the wiki only
Conference, Dial, and Pausehave undocumented options. However, for consistency should we add this option to all TwiML verbs - in my opinion no.