Add a method for validation of JSON body #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekarson
suggested changes
Jul 5, 2018
| params.put("CallSid", "CA1234567890ABCDE"); | ||
| params.put("Caller", "+14158675309"); | ||
| params.put("Digits", "1234"); | ||
| params.put("From", "+14158675309"); | ||
| params.put("To", "+18005551212"); | ||
|
|
||
| String signature = "RSOYDt4T1cUTdK1PDd93/VVr8B8="; | ||
| signature = "RSOYDt4T1cUTdK1PDd93/VVr8B8="; |
There was a problem hiding this comment.
move this to where signature is declared, since it never changes?
|
Done! |
twilio-ci
force-pushed
the
json-body-validator
branch
from
1bea436
to
639557c
Compare
|
@ekarson Updated this PR, since requests can't have both params and bodies. |
ekarson
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to validate requests that have a POST body payload, this allows us to compare it against the
bodySHA256parameter that will be sent from the Twilio Webhook.