Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more JDK versions to Travis CI config #454

Merged
merged 10 commits into from
Apr 3, 2019
Merged

Add more JDK versions to Travis CI config #454

merged 10 commits into from
Apr 3, 2019

Conversation

childish-sambino
Copy link
Contributor

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@childish-sambino childish-sambino mentioned this pull request Apr 3, 2019
Merged
1 task
dprothero
dprothero approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@dprothero dprothero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we expect the JDK12 tests to fail?

@childish-sambino
Copy link
Contributor Author

@dprothero I didn't want it to be a blocker and I haven't investigated it yet. But 12 is not-LTS from Oracle.

@childish-sambino childish-sambino merged commit 6ddb62f into twilio:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprothero dprothero dprothero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@childish-sambino @dprothero