Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [archunit] rules #464

Merged
merged 1 commit into from Jun 24, 2019
Merged

Add [archunit] rules #464

merged 1 commit into from Jun 24, 2019

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Jun 9, 2019 •
edited

  • enforce consistency across all Resource subclasses
  • block [java.util.logging] usage

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@sullis
Copy link
Contributor Author

sullis commented Jun 11, 2019

@childish-sambino

@sullis
Copy link
Contributor Author

sullis commented Jun 14, 2019

WDYT? @childish-sambino

@sullis
add [archunit] rules
bed0e1c 
- enforce consistency across all Resource subclasses
- block [java.util.logging] usage
@sullis
Copy link
Contributor Author

sullis commented Jun 19, 2019

WDYT? @childish-sambino

@childish-sambino childish-sambino changed the title add [archunit] rules Add [archunit] rules Jun 24, 2019
childish-sambino
childish-sambino approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no problem with it. LGTM!

@childish-sambino childish-sambino merged commit 0609207 into twilio:master Jun 24, 2019
@sullis sullis deleted the add-archunit-rules branch June 24, 2019 14:49
@sullis
Copy link
Contributor Author

sullis commented Jun 24, 2019

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sullis @childish-sambino