Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error details to rest and api exceptions #524

Merged
merged 6 commits into from
Apr 27, 2020

Conversation

ashish-s
Copy link
Contributor

@ashish-s ashish-s commented Apr 22, 2020

Feature

Add a new property named details to RestException add ApiException. Details is returned by selective apis to populate extra information about errors.
The Studio V2 flow api will be returning extra details with flow validation errors.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run make java from within yoyodyne, I get many more changes not included in this PR. For example, here, after generation, turns to:

throw new ApiException(
    restException.getMessage(),
    restException.getCode(),
    restException.getMoreInfo(),
    restException.getStatus(),
    restException.getDetails(),
    null
);

Could you please update this file also? Thanks!

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter type: twilio enhancement feature request on Twilio's roadmap labels Apr 22, 2020
@ashish-s
Copy link
Contributor Author

When I run make java from within yoyodyne, I get many more changes not included in this PR. For example, here, after generation, turns to:

throw new ApiException(
    restException.getMessage(),
    restException.getCode(),
    restException.getMoreInfo(),
    restException.getStatus(),
    restException.getDetails(),
    null
);

Could you please update this file also? Thanks!

running master branch of yoyodyne should not change anything. I have added tests for the new constructor in ApiExceptionTest.java

@thinkingserious
Copy link
Contributor

The PR to twilio-java should be based on your yoyodyne branch.

@thinkingserious
Copy link
Contributor

Your handcrafted code LGTM 👍 -- just need to get the generated code included. Thanks!

@ashish-s
Copy link
Contributor Author

@thinkingserious thanks for the review, i added the generated code from my branch

@childish-sambino childish-sambino merged commit 7f8931b into twilio:master Apr 27, 2020
FalguniV pushed a commit to FalguniV/twilio-java that referenced this pull request Oct 13, 2020
FalguniV pushed a commit to FalguniV/twilio-java that referenced this pull request Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for feedback waiting for feedback from the submitter type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants