-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add error details to rest and api exceptions #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run make java
from within yoyodyne, I get many more changes not included in this PR. For example, here, after generation, turns to:
throw new ApiException(
restException.getMessage(),
restException.getCode(),
restException.getMoreInfo(),
restException.getStatus(),
restException.getDetails(),
null
);
Could you please update this file also? Thanks!
running master branch of yoyodyne should not change anything. I have added tests for the new constructor in ApiExceptionTest.java |
The PR to |
Your handcrafted code LGTM 👍 -- just need to get the generated code included. Thanks! |
@thinkingserious thanks for the review, i added the generated code from my branch |
Feature
Add a new property named details to RestException add ApiException. Details is returned by selective apis to populate extra information about errors.
The Studio V2 flow api will be returning extra details with flow validation errors.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.