feat: add http logging for Java #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshanholtz
reviewed
Nov 24, 2020
eshanholtz
reviewed
Nov 30, 2020
| @@ -19,6 +25,7 @@ | |||
| private final String region; | |||
| private final String edge; | |||
| private final HttpClient httpClient; | |||
| private static final Logger logger = LogManager.getLogger("TwilioRestClient"); | |||
There was a problem hiding this comment.
Should "TwilioRestClient" be configurable?
There was a problem hiding this comment.
I don't think it would be necessary for this to be configurable because it should be the class name. I have now changed this to now use the name of the calling class based on the log4j documentation recommendation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://issues.corp.twilio.com/browse/DI-944
Checklist