feat: add new constructor to ValidationClient #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new constructor accepts a RequestConfig parameter. This allows developers to explicitly configure HTTP request behavior.
| .setConnectTimeout(CONNECTION_TIMEOUT) | ||
| .setSocketTimeout(SOCKET_TIMEOUT) | ||
| .build(); | ||
| this(accountSid, credentialSid, signingKey, privateKey, DEFAULT_REQUEST_CONFIG); |
There was a problem hiding this comment.
Can we please have a test, likely here?
There was a problem hiding this comment.
I added a new unit test: ValidationClientTest.java
Done |
There was a problem hiding this comment.
Looks like we have an issue with the new dependency. Could you please take a look? Thank you!
thinkingserious
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new constructor accepts a RequestConfig parameter.
This allows developers to explicitly configure
HTTP request behavior.
Fixes
A short description of what this PR does.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.