Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added sonarcloud integration #669

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

BrimmingDev
Copy link
Contributor

@BrimmingDev BrimmingDev commented Feb 3, 2022

Adds SonarCloud integration

Analysis on fork branch can be found at this link.

**Note: This PR will change the name of the project in SonarCloud from twilio to twilio-java once merged into main.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from the .DS_Store file.

@BrimmingDev BrimmingDev merged commit 6de0d4f into twilio:main Feb 3, 2022
@BrimmingDev BrimmingDev deleted the add-sonarcloud-integration branch February 3, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants