Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set socket config with blocking operation timeout #670

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

childish-sambino
Copy link
Contributor

Sets a default socket config with timeout for all connections. Note that this must be applied to the connection manger and not the client builder. The client builder default socket config is only used when not given a connection manager.

Fixes #663

Sets a default socket config with timeout for all connections. Note that this must be applied to the connection manger and not the client builder. The client builder default socket config is only used when not given a connection manager.
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.8% 95.8% Coverage
0.0% 0.0% Duplication

@childish-sambino childish-sambino merged commit 6ba652f into main Feb 4, 2022
@childish-sambino childish-sambino deleted the DI-1920 branch February 4, 2022 16:00
@shwetha-manvinkurke shwetha-manvinkurke changed the title [DI-1920] fix: set socket config with blocking operation timeout fix: set socket config with blocking operation timeout Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential infinite timeout caused by not setting HttpClientBuilder.setDefaultSocketConfig?
2 participants