Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update testcase to remove dependency from generated files #678

Merged
merged 2 commits into from
Apr 8, 2022
Merged

chore: update testcase to remove dependency from generated files #678

merged 2 commits into from
Apr 8, 2022

Conversation

shrutiburman
Copy link
Contributor

@shrutiburman shrutiburman commented Apr 7, 2022 •
edited
Loading

Fixes DII-351

Modified the test-case to test request method without having any dependency on generated file account.Message.
This was done as a part of java.Dockerfile refactoring (relavent PR).

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@shrutiburman shrutiburman mentioned this pull request Apr 7, 2022
Merged
14 tasks
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shrutiburman shrutiburman merged commit 026d5f2 into main Apr 8, 2022
@shrutiburman shrutiburman deleted the refactor-java-tests branch April 8, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shrutiburman @childish-sambino