-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video 7848 add changelog #100
Conversation
CHANGELOG.md
Outdated
@@ -0,0 +1,16 @@ | |||
# 1.0.0 (February 24, 2022) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we actually do the release will we have more PRs for things like updating iOS version? Just wondering if we should use a single PR for all release things including changelog, version updates, etc. Or if we will have multiple PRs.
CHANGELOG.md
Outdated
@@ -0,0 +1,16 @@ | |||
# 1.0.0 (February 24, 2022) | |||
|
|||
This is the official release of the Twilio Live Interactive Video iOS and web Apps. This project demonstrates an interactive live video streaming app that uses [Twilio Live](https://www.twilio.com/docs/live) and [Twilio Video](https://www.twilio.com/docs/video). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if official
is correct here. I'm not sure what it means in this context. Maybe This is the version 1.0.0 release...
? Or This is the initial release...
?
Also, should we mention that this also uses Sync? It might even be neat to link to @timrozum's blog post too, since it contains a wealth of knowledge about this app (suppose it might even be better in the README): https://www.twilio.com/blog/interactive-live-streaming-app-programmable-video-live-sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I think that is a good idea. I added the blog post to the README and Twilio Sync links to both the README and CHANGELOG. Please feel free to suggest edits
…ive-interactive-video into VIDEO-7848-add-changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just one last suggestion that you should be able to commit from github.
Co-authored-by: timmydoza <tmendoza@twilio.com>
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR adds a changelog to the monorepo.
Burndown
Before review
Before merge