Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video 7848 add changelog #100

Merged
merged 10 commits into from
Feb 28, 2022
Merged

Video 7848 add changelog #100

merged 10 commits into from
Feb 28, 2022

Conversation

olipyskoty
Copy link
Contributor

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds a changelog to the monorepo.

Burndown

Before review

  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with all effected platforms
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

CHANGELOG.md Outdated
@@ -0,0 +1,16 @@
# 1.0.0 (February 24, 2022)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we actually do the release will we have more PRs for things like updating iOS version? Just wondering if we should use a single PR for all release things including changelog, version updates, etc. Or if we will have multiple PRs.

CHANGELOG.md Outdated
@@ -0,0 +1,16 @@
# 1.0.0 (February 24, 2022)

This is the official release of the Twilio Live Interactive Video iOS and web Apps. This project demonstrates an interactive live video streaming app that uses [Twilio Live](https://www.twilio.com/docs/live) and [Twilio Video](https://www.twilio.com/docs/video).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if official is correct here. I'm not sure what it means in this context. Maybe This is the version 1.0.0 release...? Or This is the initial release...?

Also, should we mention that this also uses Sync? It might even be neat to link to @timrozum's blog post too, since it contains a wealth of knowledge about this app (suppose it might even be better in the README): https://www.twilio.com/blog/interactive-live-streaming-app-programmable-video-live-sync

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I think that is a good idea. I added the blog post to the README and Twilio Sync links to both the README and CHANGELOG. Please feel free to suggest edits

Copy link
Contributor

@timmydoza timmydoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one last suggestion that you should be able to commit from github.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: timmydoza <tmendoza@twilio.com>
@olipyskoty olipyskoty merged commit 35fdccc into main Feb 28, 2022
@olipyskoty olipyskoty deleted the VIDEO-7848-add-changelog branch February 28, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants