Fix host creating multiple streams #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olipyskoty
approved these changes
May 3, 2022
| onError(new Error("There was a problem connecting to Twilio's conversation service.")); | ||
| }); | ||
| }, | ||
| [onError] | ||
| [onError, chatClient] |
There was a problem hiding this comment.
looks like chatClient isn't needed in the dependency array
olipyskoty
approved these changes
May 3, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
This PR fixed a bug where the host cannot create more than one stream. It adds disconnect functions for both the SyncProvider and Chat Provider, and calls these functions whenever a participant disconnects from an event. This cleans up the chat and sync states, and there are now no errors when a host tries to create a second stream, because the stale sync and chat instances are no longer present.
Burndown
Before review
Before merge