Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/audience chat #147

Merged
merged 44 commits into from
Jul 11, 2022
Merged

Feature/audience chat #147

merged 44 commits into from
Jul 11, 2022

Conversation

olipyskoty
Copy link
Contributor

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR merges the audience-chat feature into main

Burndown

Before review

  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with all effected platforms
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

olipyskoty and others added 30 commits May 5, 2022 17:14
@olipyskoty
add conversation logic to join-stream-as-viewer endpoint
9926682
@olipyskoty
Merge pull request #118 from twilio/VIDEO-9744-backend-conversations-…
f97129b 
…support
@olipyskoty
add room_sid to backend
2872c28
@olipyskoty
add chatfeature to audience
b52c2a0
@olipyskoty
get rid of unnecesary appState updates
9a9069c
@olipyskoty
remve unused variables and keywords from chatProvider
1ab4a81
@olipyskoty
formatting fix
54ee9bb
@olipyskoty
Merge branch 'main' into feature/audience-chat
fc01ded
@olipyskoty
add feature flag to backend
4ccf84d
@olipyskoty
support feature flag on frontend
0776797
@olipyskoty
fix linter error
bfec0e2
@olipyskoty
destructure DISABLE_CHAT from serverless context
bdc678e
@olipyskoty
remove console.log
fa982aa
@olipyskoty
dont add chatGrant to token if chat is disabled
44ac27f
@olipyskoty
make hasSpeakerInvite consistent with other prejoinscreen cases
8eae506
@olipyskoty
Merge pull request #122 from twilio/VIDEO-9792-conversations-feature-…
4d24b31 
…flag
@olipyskoty
Merge branch 'feature/audience-chat' into VIDEO-9638-web-implement-chat
4c3ccf6
@olipyskoty
add conversation feature flag check for viewers
4a777de
@olipyskoty
hide chat button for viewers if disabled
65bc53c
@olipyskoty
Merge pull request #120 from twilio/VIDEO-9638-web-implement-chat
daca12b
@olipyskoty
fix bug to add chat button for viewers
dcc60c0
@olipyskoty
Make chat window open by default for desktop
25c7e72
@olipyskoty
Add mobile styling for PlayerMenuBar
7a3b017
@olipyskoty
Add MobileBottomMenuBar component
edcc455
@olipyskoty
add optional prop to exclude labels for menubar buttons
36b1bec
@olipyskoty
remove mobileBottomMenuBar component
e6c93a9
@olipyskoty
remove use of isMobile variable and replace with media queries
ce6309e
@olipyskoty
remove ability to send files via chat
da3e7c5
@olipyskoty
Update mobile menu bar buttons to be consistent with iOS
1aa9e71
@olipyskoty
update PlayerMenuBar buttons to be consistent with iOS
8ac0b5b
@olipyskoty olipyskoty merged commit 498f08c into main Jul 11, 2022
@olipyskoty olipyskoty deleted the feature/audience-chat branch July 11, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmydoza timmydoza timmydoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olipyskoty @timmydoza