Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected options.validate to default true #1022

Merged
merged 3 commits into from
May 22, 2024

Conversation

tiwarishubham635
Copy link
Contributor

Fixes #1021

Earlier if options is not passed in webhooks, it used to create options = {validate: true} but if options is passed and validate flag is missing (which expects that it will be taken true as it is the default value mentioned in the comments above), then it did not validate. Made a fix for the same.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Copy link

sonarcloud bot commented May 20, 2024

@sbansla sbansla self-requested a review May 22, 2024 12:50
@tiwarishubham635 tiwarishubham635 merged commit 0addf39 into main May 22, 2024
14 checks passed
@tiwarishubham635 tiwarishubham635 deleted the webhook_validate branch May 22, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading / Incorrect documentation for webhook validation
2 participants