Loading Reservations under a Worker by default in TaskRouter JS SDK #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwitz10
commented
Jan 21, 2016
jwitz10
commented
- Allow fetching Reservations under a Worker by default
- Allow updating Reservations under a Worker
added 2 commits
January 21, 2016 15:10
Allow updating Reservations under a Worker
|
+1, pending the backwards compatibility concern |
| @@ -4,12 +4,14 @@ var TaskRouterCapability = require('./TaskRouterCapability'); | |||
| function TaskRouterWorkerCapability(accountSid, authToken, workspaceSid, workerSid) { | |||
| TaskRouterCapability.call(this, accountSid, authToken, workspaceSid, workerSid); | |||
|
|
|||
| this.reservationsUrl = this._baseUrl + "/Tasks/**"; | |||
| this.tasksUrl = this._baseUrl + "/Tasks/**"; | |||
There was a problem hiding this comment.
same here, if I had an instance of TaskRouterWorkerCapbility that accessed tasksUrl, it would break with this update.
There was a problem hiding this comment.
Correct, but I'm not sure anyone would directly reference reservations_url since this variable's only purpose would be for generating access policies.
I can revert this if necessary though.
|
+1 |
jingming
added a commit
that referenced
this pull request
Jan 28, 2016
Loading Reservations under a Worker by default in TaskRouter JS SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.