Fixes missing identity value in token when it's not a string #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sToken constuctor
lib/jwt/AccessToken.js
Outdated
| @@ -212,6 +212,7 @@ function AccessToken(accountSid, keySid, secret, options) { | |||
| if (!keySid) { throw new Error('keySid is required'); } | |||
| if (!secret) { throw new Error('secret is required'); } | |||
| options = options || {}; | |||
| if (_.isInteger(options.identity)) { options.identity = new String(options.identity); }; | |||
There was a problem hiding this comment.
I'd rather fix the check on line 252 below. Could it just be grants.identity = String(this.identity);?
childish-sambino
added
difficulty: easy
|
@childish-sambino yes makes sense to move it there. I left the original conditional statement checking |
childish-sambino
approved these changes
Oct 18, 2019
lib/jwt/AccessToken.js
Outdated
| @@ -249,7 +249,7 @@ _.extend(AccessToken.prototype, { | |||
| } | |||
|
|
|||
| var grants = {}; | |||
| if (_.isString(this.identity)) { grants.identity = this.identity; } | |||
| if (_.isInteger(this.identity) || _.isString(this.identity)) { grants.identity = String(this.identity); }; | |||
There was a problem hiding this comment.
nit: Trailing semicolon not needed.
childish-sambino
removed
the
status: waiting for feedback
This was referenced Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438
Resolves missing identity value in token when it's not a string begin passed in the
AccessTokenconstructor.The specs of the issue ticket suggest throwing an error when identity is passed as an integer. Originally, I took this approach but I quickly realized this would cause breaking changes for anyone passing numeric values in identity option. I do not believe this is error worthy because simple converting the value to a string solves the down stream implication in the jwt.
Contributing to Twilio