Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add optional 'url' property to the webhook request validator type definition #510

Merged
merged 1 commit into from Nov 25, 2019

Conversation

hoshinokanade
Copy link
Contributor

This update the type definition according to webhooks.js. Add url to type definition of WebhookOptions so that it proper extends RequestValidatorOptions. This let typescript users to pass url with the webhook express middleware.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@childish-sambino childish-sambino changed the title Update type definition of webhook option fix: Add optional 'url' property to the webhook request validator type definition Nov 25, 2019
@childish-sambino childish-sambino merged commit d515a5a into twilio:master Nov 25, 2019
@childish-sambino childish-sambino added the type: bug bug in the library label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants