Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace moment with dayjs #515

Merged
merged 3 commits into from Dec 3, 2019
Merged

fix: replace moment with dayjs #515

merged 3 commits into from Dec 3, 2019

Conversation

cktang88
Copy link
Contributor

@cktang88 cktang88 commented Dec 3, 2019

Fix #514

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

childish-sambino
childish-sambino approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Dropped the lines from the tests since they're not needed.

@childish-sambino childish-sambino changed the title Replace moment with dayjs fix: replace moment with dayjs Dec 3, 2019
@childish-sambino childish-sambino merged commit bbe486e into twilio:master Dec 3, 2019
@snyk-bot snyk-bot mentioned this pull request Jan 10, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2020
Open
@childish-sambino childish-sambino added type: twilio enhancement feature request on Twilio's roadmap type: community enhancement feature request not on Twilio's roadmap and removed type: twilio enhancement feature request on Twilio's roadmap labels Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace momentjs with dayjs or luxon to drastically reduce bundle size
2 participants
@cktang88 @childish-sambino