Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add url parameter documentation in twilio.webhook() #541

Merged
merged 1 commit into from Mar 4, 2020

Conversation

fungiboletus
Copy link
Contributor

The url parameter is documented in validateExpressRequest but not in twilio.webhook which uses the same optional parameter.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Mention the url parameter
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@childish-sambino childish-sambino changed the title docs: url parameter in twilio.webhook() docs: add url parameter documentation in twilio.webhook() Mar 4, 2020
@childish-sambino childish-sambino merged commit 5a65128 into twilio:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants