Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent throwing an exception on 3xx response status code #614

Merged
merged 2 commits into from Sep 16, 2020
Merged

fix: Prevent throwing an exception on 3xx response status code #614

merged 2 commits into from Sep 16, 2020

Conversation

Saka7
Copy link
Contributor

@Saka7 Saka7 commented Sep 16, 2020

Fixes

Prevent throwing a RestExpection on 3XX response status code. #613

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Questions/Notes:

  • There is similar logic in other http request wrappers (update, remove, create). Do I need to change it as well?
  • I'll add tests if/when the general approach is approved

@Saka7 Saka7 changed the title Prevent throwing an exception on 3xx response status code Fix: Prevent throwing an exception on 3xx response status code Sep 16, 2020
@childish-sambino
Copy link
Contributor

  • I think just updating the fetch wrapper is fine.
  • Tests are always welcome!
  • Should update the JSdoc string on the TS file as well.
  • Have you verified locally this resolves your issue?

@childish-sambino childish-sambino changed the title Fix: Prevent throwing an exception on 3xx response status code fix: Prevent throwing an exception on 3xx response status code Sep 16, 2020
@Saka7
Copy link
Contributor Author

Saka7 commented Sep 16, 2020

  • Have you verified locally this resolves your issue?

Yes

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants