Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webhook validation with an array parameter #687

Merged

Conversation

askel4dd
Copy link
Member

@askel4dd askel4dd commented Aug 13, 2021

Fixes

Conversations API onConversationAdd webhook MessagingBinding.Address parameter can be either string or array<string> (you can see it underneath the parameters table in the Note section). twilio-node library will always fail to validate such webhooks because array parameters are not supported. In this pull-request I added a support for such parameters, but nothing more than that — deeply nested arrays, or object parameters are still not supported and I am not sure If they should be.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@shwetha-manvinkurke shwetha-manvinkurke merged commit 6f35b2a into twilio:main Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants