fix: include babel-config and global install twilio for internal testing #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiachua
approved these changes
Oct 28, 2022
|
|
||
| RUN npm install . --include=dev | ||
|
|
||
| RUN npm run build || true # tsc completes but with errors that need to be addressed. |
There was a problem hiding this comment.
curious on what the usage of "true" in this statement. Can it be RUN npm run build || #comment...
There was a problem hiding this comment.
npm run build currently has a non-zero return value (it fails) so adding a || true enables the image to continue on its merry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.