feat: TSDoc changes for generated apis #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
childish-sambino
approved these changes
Jan 4, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
rakatyal
added a commit
to twilio/twilio-oai-generator
that referenced
this pull request
Jan 4, 2023
JIRA - [DI-2350](https://issues.corp.twilio.com/browse/DI-2350) With TSDoc, we don't need to define types with @param and @returns tags. Also @Property tags are not present, they are auto defined, but the docstrings need to be defined alongside property declaration. Generated changes - twilio/twilio-node#866 Co-authored-by: childish-sambino <sharrison@twilio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - DI-2350
Related PR - twilio/twilio-oai-generator#383