Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve tsc errs in handcrafted code #878

Merged
merged 10 commits into from Jan 11, 2023
Merged

fix: resolve tsc errs in handcrafted code #878

merged 10 commits into from Jan 11, 2023

Conversation

beebzz
Copy link

@beebzz beebzz commented Jan 9, 2023

No description provided.

@beebzz beebzz marked this pull request as ready for review January 10, 2023 23:20
childish-sambino
childish-sambino approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove the --strict false flag from the build step?

@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

22.0% 22.0% Coverage
0.0% 0.0% Duplication

@beebzz beebzz merged commit ceb1138 into 4.0.0-rc Jan 11, 2023
@beebzz beebzz deleted the hc-tsc-errs branch January 11, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beebzz @childish-sambino