Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add auto-retry with exponential backoff #886

Merged
merged 2 commits into from Jan 13, 2023

Conversation

Hunga1
Copy link
Contributor

@Hunga1 Hunga1 commented Jan 12, 2023

Adds auto-retry with exponential backoff feature to auto-retry requests to the API when the API returns a 429 Too Many Requests error response. This feature is disabled by default.

Adds how-to docs for this feature to the README.

This PR is based on changes made in #741 (Thanks, @bobtfish!)

Adds auto-retry with exponential backoff on 429 error responses from the API, disabled by default. Adds unit and integration tests for feature. Adds usage docs for feature in README.
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

46.3% 46.3% Coverage
0.0% 0.0% Duplication

@Hunga1 Hunga1 linked an issue Jan 12, 2023 that may be closed by this pull request
@Hunga1 Hunga1 changed the title feat: Add auto-retry and exponential backoff feat: Add auto-retry with exponential backoff Jan 12, 2023
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

lib/base/RequestClient.ts Show resolved Hide resolved
@Hunga1 Hunga1 merged commit 5b22f39 into 4.0.0-rc Jan 13, 2023
@Hunga1 Hunga1 deleted the add_auto_retry_and_backoff branch January 13, 2023 16:51
@childish-sambino childish-sambino mentioned this pull request Jan 13, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add retries to the client for 429 (Too Many Requests) errors
2 participants