Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cluster tests' twilio relative path dependency #927

Closed
wants to merge 1 commit into from
Closed

fix: cluster tests' twilio relative path dependency #927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/cluster/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"dependencies": {
"jest": "^29.4.3",
"localtunnel": "^2.0.2",
"twilio": "../../package"
"twilio": "../../"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by-design as the cluster tests are intended to be run against the packed output:

twilio-node/.github/workflows/test-and-deploy.yml

Lines 44 to 49 in 4ab01b7

run: |
npm pack
tar -xzf twilio*.tgz
cd spec/cluster
npm install
npm run test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for the clarification. Closing this PR.

},
"scripts": {
"prepare": "tsc",
Expand Down