Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removing Test Related To Deprecated Endpoint - OAuth #963

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

KobeBrooks
Copy link
Contributor

@KobeBrooks KobeBrooks commented Oct 9, 2023

Fixes

A short description of what this PR does., removing helper test so we can deprecate this DEV/STAGE endpoint.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@KobeBrooks KobeBrooks changed the title removing test in relation to deprecated endpoint Removing Test Related To Deprecated Endpoint - OAuth Oct 9, 2023
@KobeBrooks KobeBrooks changed the title Removing Test Related To Deprecated Endpoint - OAuth chore: Removing Test Related To Deprecated Endpoint - OAuth Oct 9, 2023
@AsabuHere AsabuHere self-requested a review October 10, 2023 05:19
Copy link
Contributor

@AsabuHere AsabuHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbansla sbansla self-requested a review October 13, 2023 15:48
Copy link
Contributor

@sbansla sbansla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing oauth.

@sbansla sbansla merged commit ce0804c into twilio:main Nov 9, 2023
6 checks passed
tiwarishubham635 added a commit that referenced this pull request Nov 9, 2023
* chore: Removed LTS version (#978)

* chore: removed LTS version

* chore: removing lts from cloudscan

* chore: completely removed LTS

* chore: Update axios to 1.6 to pull in fix for CVE 2023 45857 (#971)

* Update axios to 1.6.0

Fixes CVE-2023-45857

* Explicit type return on Promise

TypeScript's automatic type resolution for the promise returned by the
function in getExponentialBackoffResponseHandler determines that it
returns a Promise<unknown>. This commit forces TypeScript to recognize
that the resolved object is of type Promise<AxiosResponse>.

---------

Co-authored-by: Shubham <tiwarishubham635@gmail.com>

* chore: twilio help changes (#958)

Co-authored-by: Shubham <tiwarishubham635@gmail.com>

* chore: Removing Test Related To Deprecated Endpoint - OAuth (#963)

* removing test in relation to deprecated endpoint

* removingn more oauth refrences

---------

Co-authored-by: sbansla <104902068+sbansla@users.noreply.github.com>

---------

Co-authored-by: Andrew Pietila <149612764+kitu-apietila@users.noreply.github.com>
Co-authored-by: kridai <kridaigoswami@gmail.com>
Co-authored-by: KobeBrooks <55289738+KobeBrooks@users.noreply.github.com>
Co-authored-by: sbansla <104902068+sbansla@users.noreply.github.com>
tiwarishubham635 added a commit that referenced this pull request Nov 13, 2023
* chore: Removed LTS version (#978)

* chore: removed LTS version

* chore: removing lts from cloudscan

* chore: completely removed LTS

* chore: Update axios to 1.6 to pull in fix for CVE 2023 45857 (#971)

* Update axios to 1.6.0

Fixes CVE-2023-45857

* Explicit type return on Promise

TypeScript's automatic type resolution for the promise returned by the
function in getExponentialBackoffResponseHandler determines that it
returns a Promise<unknown>. This commit forces TypeScript to recognize
that the resolved object is of type Promise<AxiosResponse>.

---------

Co-authored-by: Shubham <tiwarishubham635@gmail.com>

* chore: twilio help changes (#958)

Co-authored-by: Shubham <tiwarishubham635@gmail.com>

* chore: Removing Test Related To Deprecated Endpoint - OAuth (#963)

* removing test in relation to deprecated endpoint

* removingn more oauth refrences

---------

Co-authored-by: sbansla <104902068+sbansla@users.noreply.github.com>

---------

Co-authored-by: Andrew Pietila <149612764+kitu-apietila@users.noreply.github.com>
Co-authored-by: kridai <kridaigoswami@gmail.com>
Co-authored-by: KobeBrooks <55289738+KobeBrooks@users.noreply.github.com>
Co-authored-by: sbansla <104902068+sbansla@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants