Skip to content

Commit

Permalink
bump to 3.12.1
Browse files Browse the repository at this point in the history
  • Loading branch information
Doug Black committed Oct 21, 2013
1 parent 3d05244 commit aff1483
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 6 deletions.
9 changes: 9 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
twilio-php Changelog
====================

Version 3.12.1
--------------

Released on October 21, 2013

- Add support for filtering by type for IncomingPhoneNumbers.
- Add support for searching for mobile numbers for both
IncomingPhoneNumbers and AvailablePhoneNumbers.

Version 3.12.0
--------------

Expand Down
2 changes: 1 addition & 1 deletion Services/Twilio.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function Services_Twilio_autoload($className) {
*/
class Services_Twilio extends Services_Twilio_Resource
{
const USER_AGENT = 'twilio-php/3.12.0';
const USER_AGENT = 'twilio-php/3.12.1';

protected $http;
protected $retryAttempts;
Expand Down
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
# The short X.Y version.
version = '3.12'
# The full version, including alpha/beta/rc tags.
release = '3.12.0'
release = '3.12.1'

# The language for content autogenerated by Sphinx. Refer to documentation
# for a list of supported languages.
Expand Down
2 changes: 1 addition & 1 deletion docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
Status
=======

This documentation is for version 3.12.0 of `twilio-php
This documentation is for version 3.12.1 of `twilio-php
<https://www.github.com/twilio/twilio-php>`_.

Quickstart
Expand Down
6 changes: 3 additions & 3 deletions package.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@
require_once 'PEAR/PackageFileManager2.php';
PEAR::setErrorHandling(PEAR_ERROR_DIE);

$api_version = '3.12.0';
$api_version = '3.12.1';
$api_state = 'stable';

$release_version = '3.12.0';
$release_version = '3.12.1';
$release_state = 'stable';
$release_notes = 'Add support for MMS and Sip In';
$release_notes = 'Support for /Mobile endpoint';

$description = <<<DESC
A SDK (or helper library, as we're calling them) for PHP developers to write
Expand Down

4 comments on commit aff1483

@xiongchiamiov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure what happened here. There are commits on master that aren't in this tag, and commits in this tag that aren't on master. develop appears to have been abandoned for several years, so my assumption is that master is the working branch from which releases are cut. I can't do a compare against 3.12.0, because that tag still hasn't been created. And most oddly, this commit (which is where the 3.12.1 tag points) isn't even on a branch at all!

@dougblack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Taking a look.

@dougblack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the missing commits, fixed the latest tag, and added a tag for 3.12.0.

@dougblack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiongchiamiov meant to say thanks for pointing this out!

Please sign in to comment.