Status problem #116
Merged
Status problem #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 1, 2013 16:44
Sometimes the HTTP status is not included in the JSON body, we should report the HTTP status code in the TwilioRestException, not the one in the body of the message.
|
+1 kevin, looks good to ship |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115 by changing the library to use the HTTP status code (which will always be present) instead of the
statusreported in the JSON response. This will probably require a version bump (eg 3.9 to 3.10) as it may break clients. We hope we would report the same status in the body and in the HTTP response, but you never know.Also refactors a bunch of tests to use a common http mock creator, and fixes some warnings about incomplete tests