Rename "JWT" to "Twilio_JWT" #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for simple solution. |
|
Seems pretty reasonable to me. @ihumanable, you’re our resident PHP guru. Any gotchas to be aware of here? |
|
Seems reasonable, since the class is publically accessible, anyone who has written code against it might break so this should be a minor version bump. Also we should be able to replace all the hardcoded references to JWT inside the JWT class with the PHP keyword |
|
@ihumanable Good point, updated. |
|
+1 |
|
Why not just use firebase's? |
|
We're stalled on a new VERY old version of the twilio SDK due to this issue. |
|
PR is for an old version of the library. If this is still a requested feature in the 5.x libraries please open a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the most elegant solution, but in case it is I'll open this PR.